Fixed nested/spanned node issues #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a number of issues with nested/spanned nodes and simplifies the regular expressions.
|
If you go to the CKEditor demo and paste the following HTML into the source, previously it would not find and replace all of the misspelled words. I've used several situations of spanned nodes and partial words and particularly teste followed by stem cell would previously get concatinated in the old code to testestem cell which has teste in there twice making it more difficult to properly find the right instance and correct it. This update takes care of every one of these situations. <p>this is a test</p>
<p>I need to <strike>k</strike><em><strike>n<strong>o</strong></strike>o</em>w</p>
<p>if it will woork</p>
<p>testi knoow <strike>wo<u>o</u><em>r</em><strong>k</strong></strike></p>
<p>testily</p>
<p>teste</p>
<p>stem cell</p> |
| @@ -484,7 +501,9 @@ | |||
| }; | |||
|
|
|||
| TextParser.prototype.replaceWordInText = function(oldWord, newWord, text) { | |||
| var regex = new RegExp('(^|[^' + letterChars + '])(' + RegExp.escape(oldWord) + ')(?=[^' + letterChars + ']|$)', 'g'); | |||
| //MODIFIED BY Kirk Spencer | |||
| var regex = new RegExp('\\b(' + RegExp.escape(oldWord) + ')\\b', 'g'); | |||
There was a problem hiding this comment.
\b is suitable for Latin characters but it doesn't work correctly with all Unicode characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of issues with nested/spanned nodes and simplifies the regular expressions.