Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highflip-editor:init and add access log aop for web api #5

Open
wants to merge 17 commits into
base: 1.0.0
Choose a base branch
from

Conversation

TingSty
Copy link
Collaborator

@TingSty TingSty commented Apr 23, 2023

No description provided.

songtingyu and others added 8 commits April 11, 2023 16:47
2.add the convert of ListProto to java List and MapProto to java Map
3.modify the uuid strategy
4.register highflip runtime oject
5.complete HighFlipService
6.add highflip.adaptor.service.properties
@@ -30,7 +30,9 @@ spring.jpa.properties.jadira.usertype.autoRegisterUserTypes=true
# h2
spring.jpa.properties.hibernate.dialect=org.hibernate.dialect.H2Dialect
spring.datasource.driver-class-name=org.h2.Driver
spring.datasource.url=jdbc:h2:file:~/.highflip/db/highflip.db
spring.datasource.url=jdbc:h2:file:~/.highflip/db/highflip
spring.datasource.username=highflip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方不用加认证,本地文件数据库

@@ -73,5 +79,6 @@ void initialAdaptor() {
void initialDefaultAdaptor() {
DefaultAdaptor adaptor = new DefaultAdaptor();
adaptor.setup(register);
register.register(InstanceNameList.HIGHFLIP_RUNTIME, highFlipRuntime);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放到DefaultAdaptor初始化

@@ -608,4 +617,7 @@ service HighFlip{
rpc getPartner(PartnerId) returns(PartnerGetResponse);
rpc listPartner(PartnerListRequest) returns(stream PartnerListResponse);
rpc controlPartner(PartnerControlRequest) returns(Void);

// adaptor service config
rpc getServiceConfig(Void) returns(GetServiceConfigResponse);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用getConfig是不是可以?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块就不需要单独的接口了

<jmockit.version>1.43</jmockit.version>
<guava.version>31.1-jre</guava.version>
<spring.security.version>6.0.2</spring.security.version>
</properties>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些是不是可以继承父的工程属性,不需要单独设置

@@ -0,0 +1,10 @@
package com.baidu.highflip.core.adaptor;

public interface ServiceAdaptor {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以考虑放到config中

@@ -32,8 +32,8 @@
public class Data {

@Id
@Column(name = "data_id", length = 36)
@GenericGenerator(name = "id_gen", strategy = "uuid2")
@Column(name = "data_id", length = 72)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

长度是不是过长了

@TingSty
Copy link
Collaborator Author

TingSty commented Aug 1, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants