Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teaching staff #252

Merged
merged 8 commits into from
Aug 3, 2023
Merged

Add teaching staff #252

merged 8 commits into from
Aug 3, 2023

Conversation

kylianpl
Copy link
Contributor

I have done all the following:

  • added the feature
  • added documentation for the feature
  • added tests for the feature
  • ran mypy, black, and unit tests

@bain3
Copy link
Owner

bain3 commented Jul 29, 2023

Thanks for the PR! The unit test failure is unrelated.

Copy link
Owner

@bain3 bain3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things otherwise LGTM!

pronotepy/dataClasses.py Outdated Show resolved Hide resolved
pronotepy/dataClasses.py Outdated Show resolved Hide resolved
pronotepy/dataClasses.py Outdated Show resolved Hide resolved
pronotepy/dataClasses.py Outdated Show resolved Hide resolved
@kylianpl kylianpl requested a review from bain3 August 3, 2023 14:06
@bain3 bain3 merged commit 0d38cb6 into bain3:master Aug 3, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants