fix: asset manager storage migration #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrizsabin
reviewed
Nov 13, 2024
| states::read_icon_asset_manager(&env), | ||
| states::read_upgrade_authority(&env), | ||
| ) | ||
| } |
Collaborator
There was a problem hiding this comment.
since we are splitting storage items , its better to have separate getter methods as well. reading all storage item just to get one is unnecessary . separate getters would be more readable as well. If we may need entire config object , return type still can be 'config' struct. makes it more readable and type safe.
| states::read_current_limit(&env, token_address), | ||
| )) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
same here . its so unintuitive to return tuple of primitive types. Lets wrap the values in struct before returning so that caller knows which value is what. or it should only return current_limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist