handle SOR's effective price when outputAmount is 0 (#916)

balancer · Sep 9, 2024 · 1516a1b · 1516a1b
1 parent 86cdb2c
commit 1516a1b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/.changeset/six-pans-rhyme.md b/.changeset/six-pans-rhyme.md
@@ -0,0 +1,5 @@
+---
+'backend': patch
+---
+
+handle SOR's effective price when outputAmount is 0
diff --git a/modules/sor/sorV2/sorPathService.ts b/modules/sor/sorV2/sorPathService.ts
@@ -330,7 +330,7 @@ class SorPathService implements SwapService {
         const returnAmount = swapKind === SwapKind.GivenIn ? outputAmount : inputAmount;
         const swapAmount = swapKind === SwapKind.GivenIn ? inputAmount : outputAmount;
 
-        const effectivePrice = inputAmount.divDownFixed(outputAmount.scale18);
+        const effectivePrice = outputAmount.amount > 0 ? inputAmount.divDownFixed(outputAmount.scale18) : Infinity;
         const effectivePriceReversed = outputAmount.divDownFixed(inputAmount.scale18);
 
         return {
@@ -348,7 +348,13 @@ class SorPathService implements SwapService {
             swapAmountRaw: swapAmount.amount.toString(),
             returnAmount: formatUnits(returnAmount.amount, returnAmount.token.decimals),
             returnAmountRaw: returnAmount.amount.toString(),
-            effectivePrice: formatUnits(effectivePrice.amount, effectivePrice.token.decimals),
+            effectivePrice:
+                effectivePrice === Infinity
+                    ? 'Infinity'
+                    : formatUnits(
+                          (effectivePrice as TokenAmount).amount,
+                          (effectivePrice as TokenAmount).token.decimals,
+                      ),
             effectivePriceReversed: formatUnits(effectivePriceReversed.amount, effectivePriceReversed.token.decimals),
             routes: this.mapRoutes(paths, pools),
             priceImpact: {