Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle SOR's effective price when outputAmount is 0 #916

Merged
merged 1 commit into from
Sep 9, 2024
Merged

handle SOR's effective price when outputAmount is 0 #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/six-pans-rhyme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'backend': patch
---

handle SOR's effective price when outputAmount is 0
10 changes: 8 additions & 2 deletions modules/sor/sorV2/sorPathService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ class SorPathService implements SwapService {
const returnAmount = swapKind === SwapKind.GivenIn ? outputAmount : inputAmount;
const swapAmount = swapKind === SwapKind.GivenIn ? inputAmount : outputAmount;

const effectivePrice = inputAmount.divDownFixed(outputAmount.scale18);
const effectivePrice = outputAmount.amount > 0 ? inputAmount.divDownFixed(outputAmount.scale18) : Infinity;
const effectivePriceReversed = outputAmount.divDownFixed(inputAmount.scale18);

return {
Expand All @@ -348,7 +348,13 @@ class SorPathService implements SwapService {
swapAmountRaw: swapAmount.amount.toString(),
returnAmount: formatUnits(returnAmount.amount, returnAmount.token.decimals),
returnAmountRaw: returnAmount.amount.toString(),
effectivePrice: formatUnits(effectivePrice.amount, effectivePrice.token.decimals),
effectivePrice:
effectivePrice === Infinity
? 'Infinity'
: formatUnits(
(effectivePrice as TokenAmount).amount,
(effectivePrice as TokenAmount).token.decimals,
),
effectivePriceReversed: formatUnits(effectivePriceReversed.amount, effectivePriceReversed.token.decimals),
routes: this.mapRoutes(paths, pools),
priceImpact: {
Expand Down
Loading