Deployment: BalancerContractRegistryInitializer V2#286
Merged
Conversation
added 2 commits
July 11, 2025 17:56
BalancerContractRegistryInitializer V2BalancerContractRegistryInitializer V2
EndymionJkb
previously approved these changes
Jul 11, 2025
Collaborator
There was a problem hiding this comment.
Looks good. We'll have to tell governance to add LBPs manually to every new chain, then. (And update to v2 on any networks still pointing to v1; they should already have permissions.)
Not in the diff, but should also remove from the fork test, so that it passes:
info = await registry.getBalancerContractInfo(lbpFactory.address);
_validateInfo(info);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment:
BalancerContractRegistryInitializerV2Deploying only to the missing networks where the initializer was not deployed yet.
These networks need the registry to deploy LBP v2, so for the sake of simplicity I've removed LBPs from the input to prevent circular dependencies. It can be added later on; the bulk of it is in there.
Deployment tasks checklist:
readmeCHANGELOGis updatedIssue Resolution
N/A