Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add beets app #10

Merged
merged 13 commits into from
Oct 16, 2024
Merged

feat: add beets app #10

merged 13 commits into from
Oct 16, 2024

Conversation

groninge01
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mono-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 6:03am
mono-test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 6:03am

@garethfuller garethfuller linked an issue Oct 15, 2024 that may be closed by this pull request
Beets deployment #25
Closed
@groninge01 groninge01 marked this pull request as ready for review October 15, 2024 08:15
groninge01
groninge01 commented Oct 15, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
garethfuller
garethfuller requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@garethfuller garethfuller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update readme to include the beets app in the list of apps and explain that there are separate commands for spinning up beets vs bal.

garethfuller
garethfuller reviewed Oct 16, 2024
View reviewed changes
apps/beets-frontend-v3/.prettierrc.cjs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should prettier config not also be at the root level?

@garethfuller garethfuller merged commit b7da13e into main Oct 16, 2024
7 checks passed
@garethfuller garethfuller deleted the feat/add-beets-app branch October 16, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethfuller garethfuller garethfuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beets deployment
2 participants
@groninge01 @garethfuller