chore: optimize lint-staged #101
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -103,7 +103,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| @media screen and (min-width >= 768px) { | |||
| @media screen and (width >= 768px) { | |||
There was a problem hiding this comment.
stylelint threw an error on it
> @balancer/frontend-monorepo@ stylelint /home/groninge/projects/frontend-monorepo
> stylelint '**/*.css'
packages/lib/assets/css/marketing.css
106:18 ✖ Unexpected invalid media query " (min-width >= 768px)", "min-" and "max-" prefixes are not needed when using range queries media-query-no-invalid
There was a problem hiding this comment.
@uiuxxx is this linting change valid? or will it cause problems.
| "transit": { | ||
| "dependsOn": ["^transit"] | ||
| }, | ||
| "//#format": { | ||
| "outputs": ["node_modules/.cache/.prettiercache"] | ||
| }, |
There was a problem hiding this comment.
Where did this solution come from? Can you point me to the docs?
There was a problem hiding this comment.
There was a problem hiding this comment.
But what is this transit and //#format command? I've never seen that in Turbo.
There was a problem hiding this comment.
The task with double slashes is a root task.
The transit task is turbo magic to make tasks run in parallel (but I only saw that happen once).
| "format": "prettier '*.*(md|json|yaml|ts|js|tsx)' --check --cache --cache-location='node_modules/.cache/.prettiercache'", | ||
| "format:fix": "prettier '*.*(md|json|yaml|ts|js|tsx)' --write --cache --cache-location='node_modules/.cache/.prettiercache' --log-level=warn", |
There was a problem hiding this comment.
Should this not be?
| "format": "prettier '*.*(md|json|yaml|ts|js|tsx)' --check --cache --cache-location='node_modules/.cache/.prettiercache'", | |
| "format:fix": "prettier '*.*(md|json|yaml|ts|js|tsx)' --write --cache --cache-location='node_modules/.cache/.prettiercache' --log-level=warn", | |
| "format": "turbo format", | |
| "format:fix": "turbo format:fix", |
There was a problem hiding this comment.
this is needed to run prettier in the root (and only in the root)
There was a problem hiding this comment.
but it might not make sense to run eslint/prettier in the root
incrementaltotruein base tsconfig for typecheck