Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v3 nested boosted adds #154

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: v3 nested boosted adds #154

wants to merge 12 commits into from

Conversation

agualis
Copy link
Collaborator

@agualis agualis commented Nov 8, 2024 •
edited
Loading

@agualis agualis self-assigned this Nov 8, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mono-beets-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 0:39am
mono-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 0:39am
mono-test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 0:39am

@agualis agualis changed the title feat: nested boosted adds removes feat: v3 nested boosted adds Nov 8, 2024
@garethfuller
Copy link
Contributor

2% price impact for an add like that seems extreme. What's the pool link so I can check the balances? Also, looks like the price impact was actually positive for that add? Maybe we are showing positive price impacts as negative instead of zero?

@agualis
Copy link
Collaborator Author

agualis commented Nov 8, 2024

2% price impact for an add like that seems extreme. What's the pool link so I can check the balances? Also, looks like the price impact was actually positive for that add? Maybe we are showing positive price impacts as negative instead of zero?

See PR description:
https://mono-test-v3-git-feat-nestedboostedaddsremoves-balancer.vercel.app/pools/sepolia/v3/0x0270daf4ee12ccb1abc8aa365054eecb1b7f4f6b

agualis
agualis commented Nov 8, 2024
View reviewed changes
package.json
@@ -17,6 +17,8 @@
"stylelint": "stylelint '**/*.css'",
"stylelint:fix": "pnpm run stylelint -- --fix",
"test:integration": "turbo test:integration --log-order=stream --",
"test:unit:lib": "pnpm --filter lib run test:unit",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exposes lib test scripts without turbo to improve DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethfuller garethfuller Awaiting requested review from garethfuller

At least 1 approving review is required to merge this pull request.

Assignees

@agualis agualis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agualis @garethfuller