feat: permit2 swaps #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/lib/modules/transactions/transaction-steps/useSignPermit2Step.tsx
Outdated
Show resolved
Hide resolved
garethfuller
reviewed
Nov 5, 2024
packages/lib/modules/pool/actions/add-liquidity/handlers/BaseUnbalancedAddLiquidity.handler.ts
Outdated
Show resolved
Hide resolved
garethfuller
requested changes
Nov 5, 2024
Fixed after SDK fix + bump. |
garethfuller
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements v3 swaps with permit2
v3 swap works as expected (testing with dai-aave and usdc-aave which are the only standard tokens with v3 liquidity after the 10th deployment):
https://mono-test-v3-git-feat-permit2swaps-balancer.vercel.app/swap/sepolia/0xff34b3d4aee8ddcd6f9afffb6fe49bd371b8a357/0x94a9d9ac8a22534e3faca9f4e7f2e2cf85d5e4c8
swap.mp4
v3 pool swap works as expected:
https://mono-test-v3-git-feat-permit2swaps-balancer.vercel.app/pools/sepolia/v3/0xfd882a11cf794ce28b6c9952192f117cca2d2733/swap
However, some random tx simulation errors were found in the first case with some wallets/accounts. I don't fully understand the root cause yet.