-
Notifications
You must be signed in to change notification settings - Fork 303
How tos
A collection of guides for specific types of contributions.
A full release is a release that syncs develop
with master
. Full releases typically happen on a weekly release cycle which happens every Monday.
To perform a full release, follow this process:
- Make sure you have the latest changes on
develop
:git checkout develop && git pull
- Determine what the next version should be. It should usually be a minor version bump. So if the version is currently 1.2.4 the next version should be 1.3.0 etc.
- Branch off
develop
:git checkout -b release/X.X.X
- Merge master into this branch (in case anything was merged into master that wasn't merged into develop):
git fetch && git merge origin/master
- Ensure all issues in this weeks testing document are addressed.
- Make any changes or fixes required locally.
- Stage & commit your changes:
git commit -am "Describe your change"
- Increase the app's minor version in package.json to the same version as the branch with
npm version minor
- Push your branch to github
git push origin HEAD
and create a PR withmaster
as a title ofRelease X.Y.Z
and a body ofWeekly Release
- Wait for checks to pass and ask for approval.
- Once approved, change the merge type to "Create a Merge commit" and then merge your PR with
master
. It needs to be a merge commit to keep master and develop in sync. - Create a new PR with your release branch but now set the base (the branch you want to merge into) to
develop
. SetRelease X.Y.Z (DM)
as title. Set the body of this PR toOriginal: #XYZ
pointing to your last PR. - After approvals, change the merge type to "Create a Merge commit" and merge your release into
develop
. - Draft a new release setting the release version and title of the release to the version number you set in step 4 (make sure to set the release target as
master
). - Add a description for your release that is similar in structure to previous full releases.
- Publish your release.
A hotfix release is a release straight to the master
branch and therefore an immediate deployment to the production apps. Hotfixes are for when something needs to go live before the next weekly release cycle which happens every week on a Monday.
To perform a hotfix, follow this process:
- Make sure you have the latest changes on
master
:git checkout master && git pull
- Branch off
master
:git checkout -b hotfix/title-of-fix
- Make your changes locally.
- Stage & commit your changes:
git add -A && git commit -m "Describe your change"
- Push your branch to Github and create a PR.
- Once approved, merge your PR with
master
. - Create a new PR with your hotfix branch but now set the base (the branch you want to merge into) to
develop
. - After approvals, merge your hotfix into
develop
. - Draft a new release setting the release version and title of the release to the latest version number.
- Add a description for your hotfix that is similar in structure to previous hotfix releases.
- Publish your release.
Once a pool has been created there are two steps required to allow liquidity provision through the Balancer UI. In most cases pool creation triggers an automatic review/whitelist process. If this is a new pool, you could try waiting 4-8 hours before going through the process of creating whitelist PR yourself. The steps below may be followed to create a manual request to integrate tokens into the UI. We are also very open to helping with token/pool integrations on our Discord.
- Add the pool ID to the frontend allowlist.
- Add the pool tokens to the balancer Tokenlist that are not already included.
- If you're not a core repo contributor, create a pull request from a fork. Make sure to branch off the
master
branch. - Add your pool ID to the relevant network allowlist, e.g.
src/lib/config/mainnet/pools.ts
Inpools.ts
there are separate allowlists for Stable and Weighted pools, for example, if your pool is a Weighted pool add your ID to theWeighted.Allowlist
array. - Commit those changes.
- Push your branch to github and create a PR.
- Request a review from a couple of core team members.
- If you're not a core repo contributor, create a pull request from a fork on our Tokenlists repo.
- Add the token address to the relevant network array in
src/tokenlists/balancer/tokens.ts
- Push your branch to github and create a PR.
- Request a review from a couple of core team members.
- If you're not a core repo contributor, create a pull request from a fork. If you are a core contributor follow the hotfix release process.
- Add the pool ID and network to the appropriate array in
voting-gauge-pools.ts
(Mainnet, Arbitrum & Polygon) - Set an environment variable with an Infura key:
export VUE_APP_INFURA_PROJECT_ID=<YOUR_KEY>
- Run the voting gauge generation script:
npm run generate:voting-gauges
- Add the pool ID to the relevant stakable allowlist array: Mainnet, Polygon or Arbitrum
- Stage & commit these changes:
git commit -m "Update voting gauge list"
(please avoid staging your change to.env.development
) - Push your branch to github and create a PR.
- Request a review from a couple of core team member.
If the PR looks good, a core team member will merge with the master branch and run through the hotfix release process.