-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANSI_QUOTES support #196
base: master
Are you sure you want to change the base?
ANSI_QUOTES support #196
Conversation
… enabled servers. All tests pass.
CI "passes" but looks pretty messed-up: https://travis-ci.org/balderdashy/sails-mysql/builds/54893696 @dmarcelino after your work on the adapter tests, any idea why CI thinks this is passing despite failing the first test? |
@devinivy yes, I know. By default the waterline-adapter-tests return 0 (relevant code) unless |
Will CI always appear to pass for sails-mysql until that changes? |
I believe so, at least that's what I've seen on my tests. |
Any news on getting this merged? Or can we stop using double quotes as identifiers? |
@zivc, this PR breaks the tests and currently is not even mergeable (merge conflicts exist). Until those are addressed we can't merge this. |
I'm sure it wasn't like that before, back in March. I'll take another look at it this weekend. |
Is this still in an issue that needs to be addressed? |
I got hit by this as well, using an existing DB with ANSI_QUOTES enabled |
Requires this PR request to be accepted on waterline-sequel,
balderdashy/waterline-sequel#31