Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection url with special characters #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blastZ
Copy link

@blastZ blastZ commented Jul 19, 2019

If user write some config with special characters, like password is admin$$test, Url.parse() will output wrong result which used in machinepack-mysql line 225. We need warn people to use encodeURIComponent() to encode the password.
Global URL class added in node v10, I wrote it just let you know here need some warnings, because I don't see the issue page.

If user write some config with special characters, like password is admin$$test, Url.parse() will output wrong result which used in machinepack-mysql line 225. We need warn people to use encodeURIComponent() to encode the password.
Global URL class added in node v10, I wrote it just let you know here need some warnings, because I don't see the issue page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant