Remove linebreaks from long error messages #1606
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachaelshaw
reviewed
May 21, 2019
| 'after transforming columnNames back to attribute names for model `' + modelIdentity + '`, '+ | ||
| 'there is a record with a missing or invalid `'+WLModel.primaryKey+'`. '+ | ||
| 'Record: '+ | ||
| '``` '+ |
There was a problem hiding this comment.
@alxndrsn util.inspect is going to add new lines here anyway, so I think in spots like this it may just make more sense to leave the lines before and after the backticks. Any thoughts on this?
There was a problem hiding this comment.
🤷♂️ in which case I should probably just override console.log, console.error etc. 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes balderdashy/sails#4737