don't break and add default value for windows

balena-io-modules · Aug 22, 2023 · dc823ae · dc823ae
1 parent e5e3235
commit dc823ae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/windows/list.cpp b/src/windows/list.cpp
@@ -673,6 +673,7 @@ bool GetDetailData(DeviceDescriptor* device,
 
     device->isReadOnly = !isWritable;
 
+    device->attachTimestamp = NULL;
     const int64_t UNIX_TIME_START= 0x019DB1DED53E8000;
     const int64_t TICKS_PER_SECOND = 10000000;
     DWORD requiredSize;
@@ -685,9 +686,9 @@ bool GetDetailData(DeviceDescriptor* device,
         errorCode = GetLastError();
         device->error = "Couldn't SetupDiGetDeviceInterfaceDetailW: Error " +
           std::to_string(errorCode);
-        result = false;
+        //result = false;
         //TOOD is it right to break here?
-        break;
+        //break;
     }
     FILETIME filetime;
     LARGE_INTEGER li;

diff --git a/tests/drivelist.spec.ts b/tests/drivelist.spec.ts
@@ -84,6 +84,10 @@ describe('Drivelist', () => {
 					device.isUAS === null || typeof device.isUAS === 'boolean',
 					`Invalid isUAS flag: ${device.isUAS}`,
 				);
+				ok(
+					device.attachTimestamp === null || Number.isFinite(device.attachTimestamp),
+					`Invalid attachTimestamp: ${device.attachTimestamp}`,
+				);
 			});
 		});