Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: etcher-util is corrupted in RPM package #4304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

patch: etcher-util is corrupted in RPM package #4304

wants to merge 1 commit into from

Commits on Aug 31, 2024

  1. patch: etcher-util is corrupted in RPM package 

    rpmbuild strips executables by default when generating an rpm packge.
This was causing the JavaScript code bundled in the etcher-util file
to be removed, causing "Pkg: Error reading from file." whenever
etcher-util was called.

This in turn caused balena-etcher to generate the error message
`Error: (0, h.requestMetadata) is not a function` when attempting
to write an SD card.

This fixes the issue for RPM builds by replacing the `strip` command
with `true` so that rpmbuild no longer strips the executables and
the embeded code stays intact.

See: balena-io#4150

Signed-off-by: Richard Glidden <richard@glidden.org>
    @rglidden
    rglidden committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    a6cf738 View commit details
    Browse the repository at this point in the history