Merge pull request #1958 from balena-io/check-int

Only accept fully valid ints in `checkInt`
balena-io · Feb 17, 2025 · ebe52ca · ebe52ca
2 parents f89ca08 + 481ad11
commit ebe52ca
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/lib/utils.ts b/src/lib/utils.ts
@@ -24,6 +24,10 @@ export const checkInt = (num?: string): number | false => {
 	if (num == null) {
 		return false;
 	}
+	// If the string contains non-integer characters then it's not a valid integer, even if `parseInt` might turn it into one
+	if (!/^-?[0-9]+$/.test(num)) {
+		return false;
+	}
 	const n = parseInt(num, 10);
 	if (Number.isNaN(n)) {
 		return false;