HUB-2766 model code can now pass bid adjustment in tree fields, still… #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balihoo-cnorwood
suggested changes
Dec 19, 2019
balihoo-cnorwood
left a comment
balihoo-cnorwood
left a comment
There was a problem hiding this comment.
Still need to comment out console.log() and remove .js file before merging.
Contributor
Author
|
Added chad's changes, and handling of the object.path.join error. |
… need to update react code in other repo to trigger on bid field changes
…er caught these and then ran fine
…ay in modelField.coffee
…o get latest compiled js copies
balihoo-jkareliya
force-pushed
the
HUB-2766-audience-level-bid-adjustment
branch
from
590c8c4 to
26f7f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form builder Model code can now pass bid adjustment in tree fields within form builder. Field is appended to string as a "/".