Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Add voice_id to allowed fields in lecture repository update_fields method When regenerating lecture audio with an updated professor voice, the voice_id field was being silently ignored during the update. This caused lectures to retain their old voice_id even after audio regeneration. The update_fields method had an allowed_fields whitelist that did not include 'voice_id', and the return statement also omitted it. This fix: - Adds 'voice_id' to the allowed_fields set - Includes voice_id in the returned Lecture model Now when audio is regenerated with a professor's updated voice, the lecture record correctly stores the new voice_id. #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Fix: Add voice_id to allowed fields in lecture repository update_fields method When regenerating lecture audio with an updated professor voice, the voice_id field was being silently ignored during the update. This caused lectures to retain their old voice_id even after audio regeneration. The update_fields method had an allowed_fields whitelist that did not include 'voice_id', and the return statement also omitted it. This fix: - Adds 'voice_id' to the allowed_fields set - Includes voice_id in the returned Lecture model Now when audio is regenerated with a professor's updated voice, the lecture record correctly stores the new voice_id. #128
Changes from all commits
37ebecdFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing