Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nChannels not according to paper #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

nChannels not according to paper #16

wants to merge 4 commits into from

Commits on Aug 16, 2018

  1. nChannels not according to paper 

    Hi @bamos,

According to the paper, the number of channels is twice the grow_rate only for the BC type DenseNets.
Since you are giving room to not have bottleneck, we should check that before giving nChannels. If not BC, channels = 16.

I also included one doubt on the forward method and a number of parameters sanity check that does not match with the BC reported by the authors.

Regards,
Pablo
    @PabloRR100
    PabloRR100 authored Aug 16, 2018
    Configuration menu
    Copy the full SHA
    546a098 View commit details
    Browse the repository at this point in the history

  2. DenseNets-BC parameters fixed 

    Solved the problems with the parameters on the DenseNets-BC
    @PabloRR100
    PabloRR100 authored Aug 16, 2018
    Configuration menu
    Copy the full SHA
    5c14962 View commit details
    Browse the repository at this point in the history

  3. Missed out in the pooling 

    My point is that CNN models normally outputs the output of the fully connected layer.
Then this vector is passed to the Criterion(preds,targets) with the correct labels to compute the loss (CrossEntropy).

And yes the self.avgpool and the flatten are only to keep the style constant and more readable but the functionality is the same
    @PabloRR100
    PabloRR100 authored Aug 16, 2018
    Configuration menu
    Copy the full SHA
    b5f6083 View commit details
    Browse the repository at this point in the history

  4. Minor change

    @PabloRR100
    PabloRR100 authored Aug 16, 2018
    Configuration menu
    Copy the full SHA
    79a6e9d View commit details
    Browse the repository at this point in the history