Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[!feat] Refactor and Add Bitfinex #108

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

[!feat] Refactor and Add Bitfinex #108

wants to merge 22 commits into from
+3,623 −4,627

Conversation

warittornc
Copy link
Member

Implementation details

  • Do 1
  • Do 2

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the GitHub PR explorer)

@warittornc warittornc changed the base branch from main to add-binance-telemetry February 5, 2025 10:38
@warittornc warittornc changed the title refactor-and-add-bitfinex [!feat] Refactor and Add Bitfinex Feb 5, 2025
Base automatically changed from add-binance-telemetry to main February 13, 2025 09:37
taobun
taobun reviewed Feb 14, 2025
View reviewed changes
taobun
taobun reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@taobun taobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

@warittornc warittornc force-pushed the refactor-and-add-bitfinex branch from f01047f to 79ee5eb Compare February 17, 2025 08:06
@warittornc warittornc requested a review from taobun February 17, 2025 10:27
@RogerKSI RogerKSI marked this pull request as ready for review February 19, 2025 08:06
@RogerKSI RogerKSI self-requested a review February 19, 2025 08:07
nkitlabs
nkitlabs reviewed Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@nkitlabs nkitlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only telemetry for Binance worker?

@warittornc
Copy link
Member Author

only telemetry for Binance worker?

This is from a previous PR, implementation for telemtry for other workers is not in the scope of this PR and will be done later

@warittornc warittornc requested a review from nkitlabs February 26, 2025 06:28
nkitlabs
nkitlabs reviewed Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@nkitlabs nkitlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are empty files in the change, help remove them krub.

@warittornc warittornc requested a review from nkitlabs February 26, 2025 07:41
@warittornc warittornc force-pushed the refactor-and-add-bitfinex branch from 1eaff48 to 1cc3869 Compare February 26, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taobun taobun Awaiting requested review from taobun

@RogerKSI RogerKSI Awaiting requested review from RogerKSI

@nkitlabs nkitlabs Awaiting requested review from nkitlabs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@warittornc @taobun @nkitlabs