Merge pull request #144 from bandprotocol/hotfix/decode-grant-allowan…

…ce-msg fix grantAllowance decoder
bandprotocol · Mar 8, 2024 · dc8b443 · dc8b443
2 parents 256841c + bc3e41e
commit dc8b443
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 7 deletions.
diff --git a/src/components/msg/tx-index/RenderMsgDetails.res b/src/components/msg/tx-index/RenderMsgDetails.res
@@ -429,9 +429,7 @@ module Grant = {
     },
     {
       title: "Authorization URL",
-      content: PlainText( 
-        msg.url->Belt.Option.getWithDefault("-")
-      ),
+      content: PlainText(msg.url->Belt.Option.getWithDefault("-")),
       order: 4,
     },
     {
@@ -462,6 +460,7 @@ module Revoke = {
   ]
 }
 
+// TODO: add more details eg. spend_limit, expiration
 module GrantAllowance = {
   let factory = (msg: Msg.FeeGrant.GrantAllowance.t) => [
     {

diff --git a/src/utils/JsonUtils.res b/src/utils/JsonUtils.res
@@ -27,6 +27,19 @@ module Decode = {
 
   let mustDecode = (json, decoder) => json->decode(decoder)->Belt.Result.getExn
 
+  // for debug decode msg
+  // let mustDecode = (json, decoder) =>
+  //   json->(
+  //     x => {
+  //       Js.log(x)
+  //       switch x->decode(decoder) {
+  //       | Ok(decoded) => Js.log("Ok")
+  //       | Error(err) => Js.log(err)
+  //       }
+  //       x->decode(decoder)->Belt.Result.getExn
+  //     }
+  //   )
+
   type fd_type = {
     required: 'a. (list<string>, t<'a>) => 'a,
     optional: 'a. (list<string>, t<'a>) => option<'a>,

diff --git a/src/utils/Msg.res b/src/utils/Msg.res
@@ -368,21 +368,22 @@ module FeeGrant = {
     }
   }
 
+  // TODO: remove decode allowance missing in transaction
   module GrantAllowance = {
     type t = {
       grantee: Address.t,
       granter: Address.t,
-      allowance: Allowance.t,
-      allowedMessages: list<string>,
+      // allowance: Allowance.t,
+      // allowedMessages: list<string>,
     }
 
     let decode = {
       open JsonUtils.Decode
       buildObject(json => {
         granter: json.required(list{"msg", "granter"}, address),
         grantee: json.required(list{"msg", "grantee"}, address),
-        allowance: json.required(list{"msg", "allowance"}, Allowance.decoder),
-        allowedMessages: json.required(list{"msg", "allowance", "allowed_messages"}, list(string)),
+        // allowance: json.required(list{"msg", "allowance"}, Allowance.decoder),
+        // allowedMessages: json.required(list{"msg", "allowance", "allowed_messages"}, list(string)),
       })
     }
   }