Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect wallet on make oracle request page #150

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

xxibcill
Copy link
Contributor

@xxibcill xxibcill commented Aug 8, 2024

Related Issue: -

What is the feature?

  • on oracle-script execute page connect button doesn't work, when clicking on it nothing happen.
  • want to connect via Mnemonic not only Testnet

What is the solution?

  • on connect function change accountBoxState == "noShow" to
    accountBoxState == "noShow" ? setAccountBoxState(_ => "connect") : setAccountBoxState(_ => "noShow") this will make connect wallet popup appear
  • change condition when render Mnemonic from currentChainID == LaoziTestnet to currentChainID != LaoziMainnet. this make Mnemonic support on any network but mainnet

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How to test?

got to http://localhost:8000/oracle-script/445#execute then click connect

Screenshots (if any)

Other Notes

@xxibcill xxibcill requested a review from babybunn August 8, 2024 09:27
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmoscan-ax-devnet-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 9:42am
cosmoscan-rescript-devnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 9:42am
cosmoscan-rescript-devnet-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 9:42am
cosmoscan-rescript-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 9:42am
cosmoscan-rescript-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 9:42am

@xxibcill xxibcill changed the title fix connect wallet on make request fix: connect wallet on make oracle request page Aug 8, 2024
@xxibcill xxibcill merged commit dd90c1e into main Aug 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants