Fixed new install bug

banjo · Jan 22, 2021 · f2acabf · f2acabf
1 parent f2296c2
commit f2acabf
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/src/models/interfaces.ts b/src/models/interfaces.ts
@@ -31,7 +31,6 @@ export interface ThumbnailSettingsState {
     showVotes: boolean;
     infiniteScroll: boolean;
     isExtensionActive: boolean;
-    settingsInitiatedFromPopup: boolean;
 }
 
 export interface FilterOptions {

diff --git a/src/services/helpers.ts b/src/services/helpers.ts
@@ -10,12 +10,15 @@ export async function loadStorageSettings() {
         showVotes: false,
         sorting: SortingOrder.Standard,
         infiniteScroll: false,
-        isExtensionActive: false,
-        settingsInitiatedFromPopup: false,
+        isExtensionActive: true,
     };
 
     const settings = await getThumbnailSettingsStateFromStorage();
 
+    if (!settings) {
+        setThumbnailSettingsStateToStorage(initialSettings);
+    }
+
     let updated = false;
     Object.keys(initialSettings).forEach((key) => {
         if (settings[key] == null) {
@@ -24,8 +27,8 @@ export async function loadStorageSettings() {
         }
     });
 
-    if (!settings || updated) {
-        setThumbnailSettingsStateToStorage(initialSettings);
+    if (updated) {
+        setThumbnailSettingsStateToStorage(settings);
     }
 }
 

diff --git a/src/services/scrape-service.ts b/src/services/scrape-service.ts
@@ -3,7 +3,6 @@ import { getDayAfter, getDayBefore, insertAfter } from "./helpers";
 import {
     getArticleStateFromStorage,
     getExtraArticleStateFromStorage,
-    getThumbnailSettingsStateFromStorage,
     setArticleStateToStorage,
     setExtraArticleStateToStorage,
 } from "./storage-service";

diff --git a/src/thumbnails.ts b/src/thumbnails.ts
@@ -17,7 +17,6 @@ import {
     setArticleStateToStorage,
     setExtraArticleStateToStorage,
     setInitialHtmlState,
-    setThumbnailSettingsStateToStorage,
 } from "./services/storage-service";
 import { ArticleState, FilterOptions } from "./models/interfaces";
 import { SortingOrder } from "./models/enums";
@@ -36,9 +35,6 @@ import { getNextPage } from "./services/scrape-service";
     await initializeThumbnailsPage();
 })();
 
-// when button is clicked in plugin menu
-chrome.runtime.onMessage.addListener(function (msg, sender, sendResponse) {});
-
 async function changeBackToDisabledExtension() {
     const html = await getInitialHtmlState();
     document.querySelector("body").innerHTML = html;