Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sendgrid airflow #479

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Feature/sendgrid airflow #479

merged 2 commits into from
Oct 4, 2023

Conversation

ggsdc
Copy link
Member

@ggsdc ggsdc commented Oct 4, 2023

This should allow us to have sendgrid and by adding the variables into de variables file (SENDGRID_MAIL_FROM and SENDGRID_API_KEY) be able to use sendgrid to send the notification emails.

Also the backend needs to be changed in the airflow.cfg file:

[email]
email_backend = airflow.providers.sendgrid.utils.emailer.send_email

This could start from the next version.

Here is all the information.

@ggsdc ggsdc added server Issues relating to the server dependencies Pull requests that update a dependency file labels Oct 4, 2023
@ggsdc ggsdc requested a review from ampuerin October 4, 2023 18:56
@ggsdc ggsdc self-assigned this Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #479 (eafc166) into development (ddb6154) will increase coverage by 0.95%.
Report is 31 commits behind head on development.
The diff coverage is 88.61%.

@@               Coverage Diff               @@
##           development     #479      +/-   ##
===============================================
+ Coverage        78.69%   79.64%   +0.95%     
===============================================
  Files              228      262      +34     
  Lines            12526    14732    +2206     
===============================================
+ Hits              9857    11734    +1877     
- Misses            2669     2998     +329     
Flag Coverage Δ
server-tests 84.05% <87.82%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cornflow-dags/DAG/rostering/core/const.py 100.00% <ø> (ø)
cornflow-dags/DAG/rostering/core/experiment.py 97.77% <100.00%> (-0.71%) ⬇️
cornflow-dags/DAG/rostering/core/solution.py 100.00% <ø> (ø)
cornflow-dags/DAG/rostering/core/tools.py 100.00% <100.00%> (+9.52%) ⬆️
cornflow-dags/DAG/tsp/__init__.py 100.00% <100.00%> (ø)
cornflow-dags/DAG/tsp/solvers/__init__.py 100.00% <ø> (ø)
cornflow-server/cornflow/app.py 94.92% <100.00%> (+0.23%) ⬆️
cornflow-server/cornflow/cli/__init__.py 100.00% <100.00%> (ø)
cornflow-server/cornflow/cli/migrations.py 34.21% <100.00%> (ø)
cornflow-server/cornflow/cli/service.py 14.39% <100.00%> (ø)
... and 92 more

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ggsdc ggsdc merged commit 82a0d66 into development Oct 4, 2023
22 of 24 checks passed
@ggsdc ggsdc deleted the feature/sendgrid_airflow branch October 4, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file server Issues relating to the server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants