-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply offset only if not null #480
base: develop
Are you sure you want to change the base?
Conversation
Why did you close it? |
Because I can't figure out why this breaks the tests and I can do it another way |
The failing test are not your fault, I have been fighting with them the
past days. If you run them again it should work eventually
…On Fri, Oct 6, 2023, 13:43 marioncottard ***@***.***> wrote:
Because I can't figure out why this breaks the tests and I can do it
another way
—
Reply to this email directly, view it on GitHub
<#480 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF4DGHFUUUVL6JAL26JI533X57VEHAVCNFSM6AAAAAA5UKU676VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGUYDANBYHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Okay, I'll try then |
Could you solve the conflicts (due to me commenting a big part of the code to check if the test now pass) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #480 +/- ##
===============================================
- Coverage 79.04% 78.82% -0.23%
===============================================
Files 263 263
Lines 14856 14903 +47
===============================================
+ Hits 11743 11747 +4
- Misses 3113 3156 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I've left commented the tests that you commented, because even though they passed on local, they wouldn't pass here |
No description provided.