-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tsp report #536
base: develop
Are you sure you want to change the base?
Tsp report #536
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #536 +/- ##
===========================================
- Coverage 75.24% 74.78% -0.47%
===========================================
Files 258 261 +3
Lines 14428 14933 +505
Branches 2932 3027 +95
===========================================
+ Hits 10856 11167 +311
- Misses 3105 3293 +188
- Partials 467 473 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…eport` base method.
…on format of the Experiment as bridge.
cornflow-dags/DAG/activate_dags.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so the main issue is that this new version of activate dags seems like it does not work properly, or at least I am not able to make it work (for now) on my machine
So cornflow-dags and cornflow-server tests are passing. We still have an issue with the integration tests for cornflow-client, but this issue is a known one. Will try to improve it so that test pass at once and we do not have to manually rerun them for them to pass |
Coverage report is now fixed. It seems that is still far from what the minimum coverage should be. I will keep reviewing it just in case we can improve it |
…ion for wind problem
A draft example of a report using quarto + cornflow structure. I've edited (probably incorrectly) de requirements.txt of DAGs.
This PR should help standardize the way reports are stored and handled in cornflow.