Feature/monorepo #131
Open
Feature/monorepo #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…been run. This should help reduce the number of uploads in the future if this workflow is reused
ggsdc
requested review from
l-prr,
montsemunoz,
antoniogonzalezsuarez and
ngorrinm
…er modifying the description of the PR
Open
antoniogonzalezsuarez
requested changes
Jul 16, 2024
| """ | ||
|
|
||
| __path__ = __import__("pkgutil").extend_path(__path__, __name__) | ||
| __version__ = "0.2.3a1" |
There was a problem hiding this comment.
Wrong version
There was a problem hiding this comment.
Could add a test like this
import mango
from unittest import TestCase
import os
from mango.tests.const import normalize_path
class InitializeTest(TestCase):
def test_version_matches(self):
with open(normalize_path(os.path.join("..","..","pyproject.toml")),"r") as f:
pyproject = f.read()
version = pyproject.split("version = ")[1].split("\n")[0].replace('"','')
self.assertEqual(mango.__version__,version)However, this raises the following question. What would happen when we run mango.__version__ will it print base __version__ or time_series __version__
| needs: unit-testing | ||
| defaults: | ||
| run: | ||
| working-directory: ./mango_time_series |
There was a problem hiding this comment.
Why working directory mango_time_series? What happens to mango_base?
| @@ -0,0 +1,16 @@ | |||
| from unittest import TestCase | |||
|
|
|||
| from mango_time_series.mango.time_series import TimeSeriesDataFrame | |||
There was a problem hiding this comment.
Shouldn't this import be as follows:
from mango.time_series import TimeSeriesDataFrame
| def __init__(self): | ||
| pass | ||
|
|
||
| def hellow_world(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the repository structure to make sure that we can have different libraries that share the same namespace.
The main missing changes is to update all the documentation to point to the new location of the code