-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eigen decomposition; new feature to store all optimization tries; and updates to documentation #95
Conversation
I also renamed |
I added a figsize parameter to the |
@arnaudon , before we merge this PR we should probably update the online documentation of the module. |
Further improvement of the documentation: I added the missing division by in the formula for MS with the continuous combinatorial Laplacian. |
I've also added more references to the formulas for constructors. @arnaudon , I used reference [1] several times and wasn't sure if I should repeat it in every docstring or not. |
"""Plot results of pygenstability with matplotlib.""" | ||
scales = _get_scales(all_results, scale_axis=scale_axis) | ||
plt.figure(figsize=figsize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I didn't put this here, so one can call figure before this function, and have more freedom
I made a few changes to the code:
with_all_tries
in the pgs.run() function that stores the information from all optimization tries in the results dictionary under an additional key "all_tries". For some applications it is interesting to look at the different optimizations produced for the same scale, not only at the best one that is selected.