close channel only after queues have stopped their workers, fixes #83 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chart#83 Otherwise, the socket is closed and the file descriptor is freed prematurely. Due to a race condition the queues might then still be trying to use the old file descriptor which by now may already point to another unrelated socket. This may either lead to "stolen" data, data that is read accidentally by the queue worker for the already closed socket. Or it may lead to a complete deadlock, if the file descriptor now points to a blocking socket, so that `delete m->second.m_pRcvQueue` will never return because it joins the worker thread which blocks indefinitely on the wrong socket. After some time this deadlock will bring UDT completely to a halt because the above code holds the m_ControlLock into which all other work will run and block there after a while.
|
appreciate the fix. |
sequoiar
added a commit
to InstantWebP2P/nodejs-httpp
that referenced
this pull request
May 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the socket is closed and the file descriptor is freed prematurely.
Due to a race condition the queues might then still be trying to use the old
file descriptor which by now may already point to another unrelated socket. This
may either lead to "stolen" data, data that is read accidentally by the
queue worker for the already closed socket. Or it may lead to a complete deadlock,
if the file descriptor now points to a blocking socket, so that
delete m->second.m_pRcvQueuewill never return because it joins the workerthread which blocks indefinitely on the wrong socket. After some time this
deadlock will bring UDT completely to a halt because the above code holds the
m_ControlLock into which all other work will run and block there after a while.