Support editor link on QueryCollector/ExceptionsCollector

[erikn69]

This PR allow us to easy open files on editor from queries widget

I also avoid duplicating the same code again, now it uses build-in methods

laravel-debugbar/src/DataCollector/RouteCollector.php

Lines 33 to 50 in 23f6174

	protected $editors = [
	'sublime' => 'subl://open?url=file://%file&line=%line',
	'textmate' => 'txmt://open?url=file://%file&line=%line',
	'emacs' => 'emacs://open?url=file://%file&line=%line',
	'macvim' => 'mvim://open/?url=file://%file&line=%line',
	'phpstorm' => 'phpstorm://open?file=%file&line=%line',
	'idea' => 'idea://open?file=%file&line=%line',
	'vscode' => 'vscode://file/%file:%line',
	'vscode-insiders' => 'vscode-insiders://file/%file:%line',
	'vscode-remote' => 'vscode://vscode-remote/%file:%line',
	'vscode-insiders-remote' => 'vscode-insiders://vscode-remote/%file:%line',
	'vscodium' => 'vscodium://file/%file:%line',
	'nova' => 'nova://core/open/file?filename=%file&line=%line',
	'xdebug' => 'xdebug://%file@%line',
	'atom' => 'atom://core/open/file?filename=%file&line=%line',
	'espresso' => 'x-espresso://open?filepath=%file&lines=%line',
	'netbeans' => 'netbeans://open/?f=%file:%line',
	];

laravel-debugbar/src/DataCollector/ViewCollector.php

Lines 22 to 39 in 23f6174

	protected $editors = [
	'sublime' => 'subl://open?url=file://%file&line=%line',
	'textmate' => 'txmt://open?url=file://%file&line=%line',
	'emacs' => 'emacs://open?url=file://%file&line=%line',
	'macvim' => 'mvim://open/?url=file://%file&line=%line',
	'phpstorm' => 'phpstorm://open?file=%file&line=%line',
	'idea' => 'idea://open?file=%file&line=%line',
	'vscode' => 'vscode://file/%file:%line',
	'vscode-insiders' => 'vscode-insiders://file/%file:%line',
	'vscode-remote' => 'vscode://vscode-remote/%file:%line',
	'vscode-insiders-remote' => 'vscode-insiders://vscode-remote/%file:%line',
	'vscodium' => 'vscodium://file/%file:%line',
	'nova' => 'nova://core/open/file?filename=%file&line=%line',
	'xdebug' => 'xdebug://%file@%line',
	'atom' => 'atom://core/open/file?filename=%file&line=%line',
	'espresso' => 'x-espresso://open?filepath=%file&lines=%line',
	'netbeans' => 'netbeans://open/?f=%file:%line',
	];

Also getEditorHref was removed, now it uses build-in methods

Related #1258, #1359,

[erikn69]

hi @barryvdh, ready for review,
getEditorHref, replaceSitesPath, were removed in favor of the default getXdebugLink method which performs the same process(also it is supported on default js widgets)

Now,
editor can be assigned to any collector with default build-in method setEditorLinkTemplate
normalizeFilename replaced with default build-in method normalizeFilePath
debugbar.remote_sites_path can be assigned to any collector with default method setXdebugReplacements
debugbar.remote_sites_path support one or multiple paths(comma separated)

[barryvdh]

Maybe this is a silly question, but am I supposed to configure something before this works?
I'm using Laravel Herd, but the editor links all point to /app/, /resources or /vendor. Do I need to add the base_path somewhere? According to the config it should work for local development?

[erikn69]

Hi, on config, local_sites_path, remote_sites_path existed, I delegated them to the main package(xdebuglink)

laravel-debugbar/src/LaravelDebugbar.php

Lines 1225 to 1230 in 04b2868

	private function getRemoteServerReplacements()
	{
	$localPath = $this->app['config']->get('debugbar.local_sites_path', '');
	$remotePaths = array_filter(explode(',', $this->app['config']->get('debugbar.remote_sites_path', ''))) ?: [base_path()];
	return array_fill_keys($remotePaths, $localPath);

[barryvdh]

Yeah but with the default config, it redirects to the project file link, not the existing one (eg /User/Barry/etc)

[barryvdh]

The path in the view is correct, but the link should be the real path, right?

[barryvdh]

Or did I merge it incorrectly? (Had some conflicts)

[erikn69]

Queries

Views

---

config/debugbar.php

  ///
  'local_sites_path' => env('DEBUGBAR_LOCAL_SITES_PATH', ''),
  ///

.env

DEBUGBAR_LOCAL_SITES_PATH=C:\laravel\ssw

@barryvdh local_sites_path already exists before my changes

[barryvdh]

But wouldn't it make more sense that value is the base_path() by default already?

[erikn69]

yes, it would

config/debugbar.php

'local_sites_path' => env('DEBUGBAR_LOCAL_SITES_PATH', base_path()),

but that code was already like that, so I didn't modify it

[barryvdh]

Yes fixed the config in #1506 and showed just the filename to shorten a bit in #1505
Thanks!