V2 #8
Closed
V2 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @caseyWebb, In regards to #9, I've tested this with the bug I've found and your version indeed fixes this. Couldn't test it on old HFS devices tho. Have you published this version somewhere in the meanwhile? If so, I'd look into replacing the existing dep at Gatsby with your version. Thanks for your work! Btw. I've added a test to your branch, but can't figure out how to PR onto this branch, so here's the diff: https://gist.github.com/rmehner/f6b92c2cc00dae7ba7a666a988cb03c1 |
|
Forked to https://github.com/Profiscience/true-case-path, published on npm as 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Closes #5
Might close #2
Fixes issue in barsh/UniversitySite
https://travis-ci.org/caseyWebb/true-case-path
Breaking Changes
module.exports = trueCasePathSync, nowmodule.exports = { trueCasePath, trueCasePathSync }How does it work
First, make the path absolute if not already. Then, split on the delimiter (
\on Windows,/everywhere else). Then, starting at the fs root, get the contents, and try matching each against a case insensitive regex constructed with the segment. When found, append the real dir/file name. Continue.