Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

383 grpc over tls #384

Merged
merged 3 commits into from
Mar 9, 2024
Merged

383 grpc over tls #384

merged 3 commits into from
Mar 9, 2024

Conversation

bartossh
Copy link
Owner

@bartossh bartossh commented Mar 9, 2024

No description provided.

@bartossh bartossh added enhancement New feature or request feature Feature with business value. go Pull requests that update Go code labels Mar 9, 2024
@bartossh bartossh self-assigned this Mar 9, 2024
@bartossh bartossh linked an issue Mar 9, 2024 that may be closed by this pull request
Copy link

gitguardian bot commented Mar 9, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9950990 Triggered Base64 Basic Authentication 4beb81b conf/setup_bare_dependant.yaml View secret
9950991 Triggered Generic Password 4beb81b conf/setup_bare_dependant.yaml View secret
9950992 Triggered Generic Password 1310356 conf/setup_bare.yaml View secret
9950993 Triggered Generic High Entropy Secret 4beb81b conf/setup_bare_dependant.yaml View secret
9950993 Triggered Generic High Entropy Secret 4beb81b conf/setup_bare.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@bartossh bartossh merged commit 864c0a1 into main Mar 9, 2024
1 of 2 checks passed
@bartossh bartossh deleted the 383-grpc-over-tls branch March 9, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature Feature with business value. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPC over TLS.
1 participant