privacy mode for all platforms #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure you do the changes Sensei Greptile SummaryImplements privacy mode feature across all platforms (macOS, Windows, Linux) to hide server addresses from Discord Rich Presence. Users can toggle privacy mode via UI menu or CLI arguments ( Key Changes:
Issues Found:
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant CLI/UI
participant Config File
participant LogWatcher
participant RPC
User->>CLI/UI: Toggle Privacy Mode
CLI/UI->>Config File: Write privacy_mode to ~/.hytale-rpc/settings.json
Config File-->>CLI/UI: Setting saved
loop Every 3 seconds
RPC->>LogWatcher: update()
LogWatcher->>Config File: get_privacy_mode()
Config File-->>LogWatcher: privacy_mode boolean
LogWatcher->>LogWatcher: Parse game logs
LogWatcher->>LogWatcher: get_presence()
alt Privacy Mode Enabled
LogWatcher-->>RPC: ("Playing Multiplayer", "Online")
else Privacy Mode Disabled
LogWatcher-->>RPC: ("Playing Multiplayer", "Server: play.example.com")
end
RPC->>RPC: Update Discord presence
end
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Comments (1)
-
src/rpc_windows.py, line 3 (link)syntax: Inconsistent import - should be
from pypresence.presence import Presencelike other files.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
13 files reviewed, 6 comments
|
|
||
| CLIENT_ID = "1461306150497550376" | ||
|
|
||
| PRIVACY_MODE = False |
There was a problem hiding this comment.
style: PRIVACY_MODE variable added but never used in the codebase. All privacy logic reads from ~/.hytale-rpc/settings.json via get_privacy_mode() function in log watchers.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/config.py
Line: 7:7
Comment:
**style:** `PRIVACY_MODE` variable added but never used in the codebase. All privacy logic reads from `~/.hytale-rpc/settings.json` via `get_privacy_mode()` function in log watchers.
How can I resolve this? If you propose a fix, please make it concise.|
|
||
| CLIENT_ID = "1461306150497550376" | ||
|
|
||
| HIDE_SERVER_ADDRESS = False |
There was a problem hiding this comment.
style: HIDE_SERVER_ADDRESS variable added but never used in the codebase. All privacy logic reads from ~/.hytale-rpc/settings.json.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/config_macos.py
Line: 7:7
Comment:
**style:** `HIDE_SERVER_ADDRESS` variable added but never used in the codebase. All privacy logic reads from `~/.hytale-rpc/settings.json`.
How can I resolve this? If you propose a fix, please make it concise.|
|
||
| CLIENT_ID = "1461306150497550376" | ||
|
|
||
| HIDE_SERVER_ADDRESS = False |
There was a problem hiding this comment.
style: HIDE_SERVER_ADDRESS variable added but never used in the codebase. All privacy logic reads from ~/.hytale-rpc/settings.json.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/config_windows.py
Line: 7:7
Comment:
**style:** `HIDE_SERVER_ADDRESS` variable added but never used in the codebase. All privacy logic reads from `~/.hytale-rpc/settings.json`.
How can I resolve this? If you propose a fix, please make it concise.| return False | ||
|
|
||
|
|
||
| HYTALE_LOG_DIR = Path.home() / "Library/Application Support/Hytale/UserData/Logs" |
There was a problem hiding this comment.
logic: Hardcoded macOS path in generic Linux/Windows log watcher - should use find_hytale_log_dir() from config.py instead.
Suggested change
| HYTALE_LOG_DIR = Path.home() / "Library/Application Support/Hytale/UserData/Logs" | |
| from .config import find_hytale_log_dir | |
| HYTALE_LOG_DIR = find_hytale_log_dir() |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/log_watcher.py
Line: 23:23
Comment:
**logic:** Hardcoded macOS path in generic Linux/Windows log watcher - should use `find_hytale_log_dir()` from config.py instead.
```suggestion
from .config import find_hytale_log_dir
HYTALE_LOG_DIR = find_hytale_log_dir()
```
How can I resolve this? If you propose a fix, please make it concise.| from .log_watcher_macos import LogWatcher | ||
| else: | ||
| from .config import CLIENT_ID, HYTALE_PROCESS_NAMES, DISCORD_PROCESS_NAMES | ||
| from .config import CLIENT_ID, HYTALE_PROCESS_NAMES, DISCORD_PROCESS_NAMES, HIDE_SERVER_ADDRESS |
There was a problem hiding this comment.
style: HIDE_SERVER_ADDRESS imported but never used in this file.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/rpc_macos.py
Line: 8:8
Comment:
**style:** `HIDE_SERVER_ADDRESS` imported but never used in this file.
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.