Skip to content

Conversation

@aspiers
Copy link

@aspiers aspiers commented Apr 25, 2015

Eventually, this will probably be taken care of by setup.py or similar. For
now, it's better not to rename the source file, because that would break every
existing pull request.

Closes #30 and closes #47.

@basak
Copy link
Owner

basak commented Apr 26, 2015

This would break the other examples in the same README.md. Can we hold and commit all necessary changes needed for the rename all at once (not necessarily in the same commit, but in time, so users are most likely to continue seeing everything consistent)?

@basak
Copy link
Owner

basak commented Apr 26, 2015

I'm not sure what "all changes" means exactly - are there self-references anywhere else in this repo? Also, maybe we could prepare a pull request for Joey for git-annex at the same time? He probably won't want to commit the rename until we have done so, but maybe we could commit the rename here and send a pre-prepared pull request to Joey as soon as it's done.

My concern is just that it doesn't end up half done because we started it and then got distracted by other priorities (as often happens).

Eventually, this will probably be taken care of by setup.py or similar.
For now, it's better not to rename the source file, because that would
break every existing pull request.

Closes basak#30 and closes basak#47.
@aspiers
Copy link
Author

aspiers commented Apr 26, 2015

Oops, you're right. Updated the commit with the other references.

Good idea about sending a patch to Joey too, although he doesn't accept pull requests AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

please provide a glacier-cli command glacier binary is in conflict with boto's glacier binary

2 participants