Open
Conversation
Removed several optional configuration parameters and related logic from the Adaptive Cover integration's config flow.
Fix initialization of lux and irradiance toggles to True if the entities are configured, preventing issues during the first refresh.
This file implements the AdaptiveGeneralCover class and related data classes for managing cover states based on solar data and environmental conditions.
Fix synchronization issue on entity addition to Home Assistant.
Refactor config flow for Adaptive Cover integration, updating schemas and adding optional parameters.
Refactor helper functions to use type hints and remove unused code.
Added docstrings to setter methods for clarity.
…on property Add a noqa comment to suppress linting warning for min_pos check.
Refactor climate mode data initialization to use named arguments for clarity and avoid pylint warnings. Ensure time variable is initialized to prevent UnboundLocalError.
Refactor get_current_temperature to return None if unavailable and handle 0.0°C correctly. Update checks for outside and inside temperatures to use None checks.
Fixes a bug where switches appear OFF after a restart by ensuring the update listener is registered properly.
Refactor normal_with_presence method to prioritize winter check over lux/weather conditions. Improve handling of sun presence for better solar heat capture.
Sun NOT in window → default
Sun in window
├─ WINTER → 100% open (capture heat, regardless of lux/weather)
├─ SUMMER
│ ├─ transparent blind → basic calculated (sheer: shade only)
│ └─ opaque blind → 0% closed (preserve indoor cool)
└─ INTERMEDIATE
├─ overcast/low lux → default
└─ sunny → basic calculated (shade only)
Error: R] [JSON] Invalid JSON file translations/es.json
Contributor
Author
|
up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Optimization : Formal validation
Integrate correction PR # 439
Correction for Lux sensor activation on restart
Suppress unused variables
Correct a Race condition between outside temp sensor withc is in witer mode and inside sensor in intermediary mode.
suppression spanish translation : cause error in integration
Bump actions/checkout from 4.2.1 to 6.0.0](#436
How has this been tested?
Test on my onw installation
Types of changes
Checklist