Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove basenames modal #1061

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix/remove basenames modal #1061

merged 3 commits into from
Oct 11, 2024

Conversation

brendan-defi
Copy link
Collaborator

What changed? Why?

  • removed basenames modal from web and docs

Notes to reviewers

How has it been tested?
locally

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 10:10pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 10:10pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 11, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@kirkas kirkas self-requested a review October 11, 2024 21:29
kirkas
kirkas previously approved these changes Oct 11, 2024
apps/base-docs/tutorials/data.json Outdated Show resolved Hide resolved
@brendan-defi brendan-defi merged commit 28453fe into master Oct 11, 2024
8 checks passed
@brendan-defi brendan-defi deleted the fix/remove-basenames-modal branch October 11, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants