Feature/refactor and alarms #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 24, 2017 15:51
…disable actions. aurora and sqlserver skip actions
toshke
force-pushed
the
feature/refactor-and-alarms
branch
from
d4cea72 to
2bcdc16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Refactor
Major code refactoring. Rather than having all resource handlers in single class, start/stop handlers are produced via factory pattern. Input to factory is CloudFormation resource type.
Support for cloudwatch alarms
CloudWatch Alarms will have their actions enabled or disabled in case of start (stopping) CloudFormation stack.
Testing
As Issue #6 is still under development, this has been tested manually, on CloudFormation stack with all resources.