Skip to content

Conversation

@kfirstri
Copy link
Collaborator

@kfirstri kfirstri commented Feb 12, 2026

Note

Description

This PR refactors HTTP request timeout configuration in the Base44 CLI by removing the global 3-minute timeout from the base HTTP client and adding operation-specific timeouts to individual API calls. This provides better control over timeout behavior for different operations - shorter timeouts for quick operations like entity and agent syncs (1 minute), longer timeouts for site deployments (3 minutes), and no timeout for function deployments which can take indefinite time.

Related Issue

None

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Other (please describe):

Changes Made

  • Removed global timeout: 180_000 (3 minutes) from base44Client in src/core/clients/base44-client.ts
  • Added timeout: 60_000 (1 minute) to entity sync API call in src/core/resources/entity/api.ts
  • Added timeout: 60_000 (1 minute) to agent push API call in src/core/resources/agent/api.ts
  • Changed function deployment timeout from 120_000 to false (no timeout) in src/core/resources/function/api.ts
  • Added timeout: 180_000 (3 minutes) to site deployment API call in src/core/site/api.ts
  • Updated test expectations in tests/core/agents.spec.ts to verify timeout parameters

Testing

  • I have tested these changes locally
  • I have added/updated tests as needed
  • All tests pass (npm test)

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have updated AGENTS.md if I made architectural changes

Additional Notes

This change improves timeout handling by:

  • Allowing quick operations (entities, agents) to fail faster with 1-minute timeouts
  • Preventing function deployments from timing out prematurely (no timeout limit)
  • Maintaining appropriate timeout for site uploads (3 minutes)
  • Following the principle of operation-specific configuration over global defaults

The function deployment timeout was changed to false (unlimited) because backend function compilation and deployment can take variable amounts of time depending on complexity and dependencies.


🤖 Generated by Claude | 2026-02-12 21:45 UTC

@kfirstri kfirstri self-assigned this Feb 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

🚀 Package Preview Available!


Install this PR's preview build with npm:

npm i @base44-preview/cli@0.0.31-pr.243.ce802aa

Prefer not to change any import paths? Install using npm alias so your code still imports base44:

npm i "base44@npm:@base44-preview/cli@0.0.31-pr.243.ce802aa"

Or add it to your package.json dependencies:

{
  "dependencies": {
    "base44": "npm:@base44-preview/cli@0.0.31-pr.243.ce802aa"
  }
}

Preview published to npm registry — try new features instantly!

@claude
Copy link

claude bot commented Feb 12, 2026

README check ran. 11 issue(s) found and applied: Added missing eject and connectors push commands; updated all command descriptions to match code exactly (e.g., create, deploy, link, logout, whoami, agents pull, agents push, entities push). README.md has been updated in this branch.

@claude
Copy link

claude bot commented Feb 12, 2026

README check ran. 4 issue(s) found and applied: added missing eject command, added missing connectors push command, updated command descriptions to match source code exactly (e.g. create, deploy, link, logout, whoami, agents pull/push). README.md has been updated in this branch.

@kfirstri kfirstri merged commit 73b9d2f into main Feb 12, 2026
9 checks passed
@kfirstri kfirstri deleted the improve-timeouts branch February 12, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant