fix: readme-check tool permissions and prompt clarity #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Claude agent's tool calls were silently denied during PR #72: - Agent used Edit (not in allowed-tools) instead of Write - Agent chained git commands with && which didn't match individual patterns - Bare git push (no args) didn't match Bash(git push *) Fixes: - Add Edit to allowed-tools alongside Write - Add Bash(git push) for bare git push without args - Instruct agent to run git commands as separate Bash calls - Only post PR comment after confirming git push succeeded Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
readme-checkworkflow where Claude's tool calls were silently denied by theclaude_argssandbox, causing it to post a misleading "README updated" comment while nothing actually changed (see PR test: add example-skill to verify readme-check workflow #72)Edittool not allowed, chained git commands rejected by individual Bash patterns, baregit pushnot matchingBash(git push *)Changes
claude_args: AddedEditto allowed tools; addedBash(git push)pattern for bare push&&/;); only post PR comment after confirming push succeededTest plan
mainMade with Cursor