Add JSON response support for notifications/tray
#2398
+49
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svara
commented
Jan 19, 2026
| json.creator notification.creator, partial: "users/user", as: :user | ||
| json.creator do | ||
| json.partial! "users/user", user: notification.creator | ||
| json.avatar_url user_avatar_url(notification.creator) |
Contributor
Author
There was a problem hiding this comment.
@jorgemanrubia Do you see any reason why we couldn't include the avatar url in the existing user partial?
Collaborator
There was a problem hiding this comment.
@svara should be fine to add it to the user partial
alpkeser
force-pushed
the
notifications-tray-api
branch
from
847574f to
e6e395f
Compare
Add avatar url, board name, and column.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Includes assignee users in the card object for display in notification UI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
These fields were added but are not used by the iOS client. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
alpkeser
force-pushed
the
notifications-tray-api
branch
from
e6e395f to
a3aefba
Compare
alpkeser
force-pushed
the
notifications-tray-api
branch
from
f604f0e to
d954ec9
Compare
alpkeser
reviewed
Jan 29, 2026
| def show | ||
| @notifications = Current.user.notifications.preloaded.unread.ordered.limit(100) | ||
| @notifications = unread_notifications | ||
| if include_unread? |
There was a problem hiding this comment.
@svara added this query parameter instead of checking for format.json. Let me know if you have any concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
notification/trayJSON for mobile app requirements: