Modal dialogs: smoother animations and QR code dialog improvements #2437
+23
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
.dialoganimations by applyingease-outeasing1, increasing the initialscale2, centeringtransform-origin, and making the closing animation faster than the opening one.--panel-sizeto the QR code dialogs (invites and instant login) so they don't go full-width on desktop.text-wrap: balancefor that copy.[x]).transition-properties so they're more maintainable.Before:
qr-before.mp4
After:
qr-after.mp4
Footnotes
https://emilkowal.ski/ui/7-practical-animation-tips#4.-choose-the-right-easing ↩
https://emilkowal.ski/ui/7-practical-animation-tips#2.-don’t-animate-from-scale(0) ↩