Skip to content

Conversation

@kevinmcconnell
Copy link
Collaborator

This shortens URLs in the self-hosted case, where external account ID is typically a small number.

@flavorjones are you aware of any reasons that we still need to keep the padding?

This shortens URLs in the self-hosted case, where external account ID is
typically a small number.
Copy link
Member

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're correct, there's no good reason it needs to be (at least) seven characters. That convention was lifted from Basecamp's account slug middleware and at the time we still weren't sure whether we were going to allow custom tenant names or not so I opted for minimal changes. But given where we are now, yeah, let's trim it.

@kevinmcconnell kevinmcconnell merged commit feaeaf5 into main Jan 28, 2026
12 checks passed
@kevinmcconnell kevinmcconnell deleted the remove-zero-padding-from-account-slug branch January 28, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants