Fix Safari transition glitches #2451
Open
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a 1px vertical shift and font rendering glitches in desktop Safari.
Before:
safari-before-1.mp4
After:
safari-after-1.mp4
Before:
safari-before-2.mp4
After:
safari-after-2.mp4
Note
This removes the 100ms brightness transition from buttons since Safari doesn't like
filtertransitions. The difference is barely noticeable because the transition is very quick. There's a workaround that seems to work well (will-change: filter), but using it may lead to performance issues when there are many buttons on the page.