Skip to content

Fix Safari transition glitches #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nqst wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix Safari transition glitches #2451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6691262
Remove `filter` from transition properties to fix glitches in Safari
nqst Jan 27, 2026
9b05c9b
Fix card column glitches
nqst Jan 27, 2026
62e8bb6
Fix blurry card columns
nqst Jan 28, 2026
c15d7ae
Cleanup
nqst Jan 28, 2026
7cda948
Update comment
nqst Jan 28, 2026
b937a1e
Merge branch 'main' into fix-safari-glitches
nqst Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/stylesheets/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

:is(a, button, input, textarea, .switch, .btn) {
transition: 100ms ease-out;
transition-property: background-color, border-color, box-shadow, filter, outline;
transition-property: background-color, border-color, box-shadow, outline;
touch-action: manipulation;

/* Keyboard navigation */
Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/buttons.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
pointer-events: auto;
position: relative;
transition: 100ms ease-out;
transition-property: background-color, border, box-shadow, color, filter, opacity, scale;
transition-property: background-color, border, box-shadow, color, opacity, scale;

@media (any-hover: hover) {
&:hover {
Expand Down
5 changes: 3 additions & 2 deletions app/assets/stylesheets/card-columns.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,16 @@
.cards__transition-container {
block-size: 100%;
border-radius: calc(var(--column-width-collapsed) / 2);
translate: 0 0.5ch; /* Allow a little room for the mini bubble */
margin-block-start: 0.5ch; /* Allow a little room for the mini bubble */
transition: translate var(--column-transition-duration) var(--ease-out-overshoot-subtle);

@media (min-width: 640px) {
.is-expanded & {
translate: 0 0.5ch; /* Allow a little room for the mini bubble */
translate: 0; /* Animate back from collapsed state */
}

.is-collapsed & {
margin-block-start: 0;
translate: 0 var(--column-width-collapsed);
}
}
Expand Down