Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set KAMAL_DESTINATION when loading config #1019

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set KAMAL_DESTINATION when loading config #1019

wants to merge 2 commits into from
+9 −0

Conversation

nickhammond
Copy link
Contributor

No description provided.

@nickhammond nickhammond mentioned this pull request Oct 1, 2024
Closed
@jeromedalbert
Copy link
Contributor

jeromedalbert commented Oct 1, 2024 •
edited
Loading

I'm glad to see that this issue is being tackled. I have needed ENV['KAMAL_DESTINATION'] in my config/deploy.yml so I can do Dotenv.load(".kamal/secrets.#{ENV['KAMAL_DESTINATION']}") or something similar with Dotenv.parse.

This PR would remove my hacky workaround of pre-parsing the destination from ARGV in my bin/kamal binstub and setting the environment variable then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmb djmb djmb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickhammond @jeromedalbert @djmb