Fix #528 - Allow roles to have volumes #613
Open
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcraigjohnson
force-pushed
the
fix-issue-528
branch
from
8c5e74c
to
909a365
Compare
samcraigjohnson
force-pushed
the
fix-issue-528
branch
from
909a365
to
47af535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
volumescommand only works if you aren't using server roles. It makes sense that you would want to be able to control which volumes are mounted inside of each container.This fixes that by allowing
volumesto also be placed inside the role level configuration. Then the role level and outer level configs are both used in thedocker runcommand so it should work fine for existing configurations.