Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip shell option value if it's nil #774

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xiaohui-zhangxh
Copy link
Contributor

I think optionize shouldn't output the key which value is nil, we should treate nil as removing the key. If we need a key-only argument, the value should be true instead of nil.

eg.

production environment, we use http provider for traerik

# config/deploy.yaml
traefik:
  args:
    providers.http.endpoint: "http://app:3000/v1/traefik/routes"

development environment, we are changing http provider to file provier

# config/deploy.dev.yaml
traefik:
  args:
    providers.http.endpoint: null
    providers.file.directory: "/etc/traefik/enabled-sites"
    providers.file.watch: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant