builder/cache/options: fix order of build args when using registry #950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When using the build cache with the
registry
cache type the order of options given todocker build --cache-to
appears to be significant and theref
option MUST come first, directly after thetype=registry
option.The error looks like the following with the existing implementation that appends the
ref
option at the end of thebuilder/cache/options
:I can't just remove the other options because the
oci-mediatypes=true,image-manifest=true
options are required to use the build cache with ECR.